-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show lines in our facet tests that are outside of the range #2207
Conversation
b365c71
to
b549dd7
Compare
I think this is a win cc/ @josharian @AndreasArvidsson |
@wenkokke this will make some of your test files shorter |
i'm a tentative +1. maybe a +0. |
Looking at the fixtures themselves, rather than the diffs, I feel the same. I do feel it makes some tests a lot easier to read, but can see how it might slightly reduce clarity on others |
I think this is an improvement. I do wonder if we also should remove empty range lines? Having those empty lines in the middle of the code block doesn't really help you with readability. Also now that we exclude lines outside of the range I'm tempted to go back to having the start range be above the code. source:
scope:
|
I disagree on both counts 😅. Shall we aim to discuss? I'd be inclined to merge this in the meantime as I think we all tentatively agree it's an improvement? |
Ok with me |
Sounds good. I'll merge once you give it the stamp |
) Fixes #2164 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
Fixes #2164
Checklist